[PATCH] D146208: [ASAN] Support memory checks on vp.load/store.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1487
+      if (EVL) {
+        Value *ExtEVL = IRB.CreateZExt(EVL, IntptrTy);
+        Value *InEVLRange = IRB.CreateICmpULT(Index, ExtEVL);
----------------
reames wrote:
> I may be missing something here, but isn't EVL just an upper bound on the loop?  If so, maybe we shouldn't use for the ForEachLane variant and should instead have a variant which takes End explicitly?
Agree. I am too conservative to change the original code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146208/new/

https://reviews.llvm.org/D146208