[PATCH] D142084: [RFC][X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

Thu Mar 16 15:45:14 PDT 2023

smeenai added inline comments.

================
Comment at: llvm/test/TableGen/x86-auto-memfold.td:2
+// RUN: llvm-tblgen -gen-x86-fold-tables %p/../../lib/Target/X86/X86.td -I %p/../../include -I %p/../../lib/Target/X86/ -I %p/../../include/ -I %p/../../lib/Target/ -o %t1
+// RUN: cmp %p/../../lib/Target/X86/X86MemFoldTables.inc %t1 --ignore-initial=0:568
----------------
steven_wu wrote:
> yubing wrote:
> > skan wrote:
> > > Question: what do we skip here?
> > the first 568 bytes are:
> > 
> > ```
> > /*===- TableGen'erated file -------------------------------------*- C++ -*-===*\
> > |*                                                                            *|
> > |* X86 fold tables                                                            *|
> > |*                                                                            *|
> > |* Automatically generated file, do not edit!                                 *|
> > |*                                                                            *|
> > \*===----------------------------------------------------------------------===*/
> > ```
> From the manpage of `cmp`, it should be like:
> 
> cmp [OPTIONS] file1 file2
> 
> There are some implementation that cannot take `--ignore-initial` after the files. Can you move it to the front?
This was breaking our tests on macOS as well, so I pushed rG7e271c2a8552 to fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084