[PATCH] D146241: [BOLT] Manage section naming/cloning in RewriteInstance

[Denis Revunov via Phabricator via llvm-commits]

treapster added inline comments.


================
Comment at: bolt/lib/Core/BinaryEmitter.cpp:1162
+        Section.getOutputName() == BC.getMainCodeSectionName() ||
+        Section.getOutputName().startswith(OrgSecPrefix))
       continue;
----------------
I'm somewhat confused about this part because intuitively we should not have relocations for .bolt.org sections, but there are such cases(e.g instrumentation-dup-jts test) and i'm not sure sure it's ok to not emit them, but it's working.. I'll dig more into it.
As of .text, we should probably fail on assert here if it has relocations?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146241/new/

https://reviews.llvm.org/D146241