[PATCH] D146085: [BOLT] Add .relr.dyn section support

[Rafael Auler via Phabricator via llvm-commits]

rafauler accepted this revision.
rafauler added a comment.
This revision is now accepted and ready to land.

LGTM with nits:



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:5696
+  } else if (!DynamicRelrEntrySize) {
+    errs() << "BOLT-ERROR: expeting DT_RELRENT to be presented "
+           << "in DYNAMIC section";
----------------
expected
presented -> present


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:5697
+    errs() << "BOLT-ERROR: expeting DT_RELRENT to be presented "
+           << "in DYNAMIC section";
+    exit(1);
----------------
\n


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:5700
+  } else if (DynamicRelrSize % DynamicRelrEntrySize) {
+    errs() << "BOLT-ERROR: Expected RELR table size to be divisible "
+           << "by RELR entry size";
----------------
Expected -> expected


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:5701
+    errs() << "BOLT-ERROR: Expected RELR table size to be divisible "
+           << "by RELR entry size";
+    exit(1);
----------------
\n


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146085/new/

https://reviews.llvm.org/D146085