[PATCH] D146257: Consume "size_text" instead of size..text or size.__text

[Jessica Paquette via Phabricator via llvm-commits]

paquette created this revision.
Herald added a subscriber: dkolesnichenko.
Herald added a project: All.
paquette requested review of this revision.

This is meant to be in tandem with a change to the llvm-test-suite.

D109576 <https://reviews.llvm.org/D109576> broke code size metric collection on Darwin platforms.

This teaches LNT to accept strings like `size_text` instead of `size.__text` or `size..text`, which are platform-specific.


Repository:
  rLNT LNT

https://reviews.llvm.org/D146257

Files:
  lnt/tests/test_suite.py


Index: lnt/tests/test_suite.py
===================================================================
--- lnt/tests/test_suite.py
+++ lnt/tests/test_suite.py
@@ -80,7 +80,7 @@
             fail;*;*;*;
         {%- else -%}
             pass;{{ test.metrics.compile_time if test.metrics }};\
-{{ test.metrics['size..text'] if test.metrics }};\
+{{ test.metrics['size_text'] if test.metrics }};\
 {{ test.metrics.hash if test.metrics }};
         {%- endif -%}
         {%- if test.code == "FAIL" or test.code == "NOEXE" -%}
@@ -713,7 +713,7 @@
             'score': 'score',
             'hash': 'hash',
             'link_time': 'compile',
-            'size..text': 'code_size',
+            'size_text': 'code_size',
             'mem_bytes': 'mem',
             'link_mem_bytes': 'mem'
         }
@@ -723,7 +723,7 @@
             'score': float,
             'hash': str,
             'link_time': float,
-            'size..text': float,
+            'size_text': float,
             'mem_bytes': float,
             'link_mem_bytes': float
         }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146257.505922.patch
Type: text/x-patch
Size: 1053 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230316/ddee93cb/attachment.bin>