[PATCH] D146238: [StandardInstrumentations] Check that module analyses are properly invalidated

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1126
       FAM.registerPass([&] { return PreservedFunctionHashAnalysis(); });
+      MAM.registerPass([&] { return PreservedModuleHashAnalysis(); });
       Registered = true;
----------------
Do this outside the pass callback?


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1204
+      }
+    }
   });
----------------
Hm, does that mean that in most cases we're going to verify both all functions via the function hash, and then again using the module hash (which includes all function hashes)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146238/new/

https://reviews.llvm.org/D146238