[PATCH] D146182: [llvm-profdata] Fixed various issue with Sample Profile Reader

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish requested changes to this revision.
snehasish added a comment.
This revision now requires changes to proceed.

Can you split out the uint64_t type changes into a separate patch?



================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:1071
 std::error_code SampleProfileReaderBinary::readNameTable() {
-  auto Size = readNumber<uint32_t>();
+  auto Size = readNumber<uint64_t>();
   if (std::error_code EC = Size.getError())
----------------
Just to confirm, the reason this is safe for existing profiles on disk is because the underlying number is uleb128 encoded?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146182/new/

https://reviews.llvm.org/D146182