[PATCH] D145279: Attributor: Assume handling for nofpclass

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 12:29:58 PDT 2023


jdoerfert accepted this revision.
jdoerfert added a comment.

LG, two nits.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4285
+
+  // Try to restrict the range based on information from assumptions.
+  for (auto &AssumeVH : Q.AC->assumptionsFor(V)) {
----------------
Copy-paste.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:10309
       if (Instruction *CtxI = getCtxI())
         followUsesInMBEC(*this, A, getState(), *CtxI);
   }
----------------
We don't need two places to followUses


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145279/new/

https://reviews.llvm.org/D145279



More information about the llvm-commits mailing list