[PATCH] D145233: Attributor: Start inferring nofpclass

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.

LG, assuming we actually don't need the manifest. If we do, we need to see why and what to do about it.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:10251
+                        UsedAssumedInformation))
+      return ChangeStatus::UNCHANGED;
+
----------------
We never call manifest for what we assume is dead (https://github.com/llvm/llvm-project/blob/2e8ef93439a4a430fe5f96b9d999ce96405345f4/llvm/lib/Transforms/IPO/Attributor.cpp#L2141).
If you saw a problem, we need to address it generally.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:10262
+    return AANoFPClass::manifest(A);
+  }
+
----------------
I doubt you need a manifest. Do you see the problems you are trying to avoid above?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145233/new/

https://reviews.llvm.org/D145233