[PATCH] D145299: [InstCombine] Generate better code for std::bit_ceil

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 11:15:48 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/bit_ceil.ll:14
 ;
   %dec = add i32 %x, -1
   %ctlz = tail call i32 @llvm.ctlz.i32(i32 %dec, i1 false)
----------------
Can you add some tests where there are prior transformations on `%x` (some binops like add/sub/shift/and/xor/or) to test that this impl is is reasonable robust in finding the pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145299/new/

https://reviews.llvm.org/D145299



More information about the llvm-commits mailing list