[PATCH] D144878: __builtin_FILE_NAME()

Ilya Karapsin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 08:58:30 PDT 2023


karapsinie marked an inline comment as done.
karapsinie added a comment.

In D144878#4199297 <https://reviews.llvm.org/D144878#4199297>, @aaron.ballman wrote:

> LGTM aside from a small formatting issue. Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution?

Yes, I need help with landing.
Name: Ilya Karapsin.
Email: ilya84050 at gmail.com.



================
Comment at: clang/lib/Parse/ParseExpr.cpp:805-807
+/// [C++11] simple-type-specifier braced-init-list [C++11 5.2.3]
 /// [C++]   typename-specifier '(' expression-list[opt] ')'         [C++ 5.2.3]
+/// [C++11] typename-specifier braced-init-list [C++11 5.2.3]
----------------
aaron.ballman wrote:
> Formatting here also got messed up a bit.
If these two lines are restored, "git-clang-format" will break the comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144878/new/

https://reviews.llvm.org/D144878



More information about the llvm-commits mailing list