[PATCH] D146119: [llvm-readobj][AMDGPU] Bypass MD verification for PAL

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 06:37:52 PDT 2023


Pierre-vh added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5435
+
+    // FIXME: Metadata Verifier doesn't work with AMDPAL MD.
+    //  This is a ugly workaround to avoid the verifier.
----------------
arsenm wrote:
> Why, I don't understand?
It's only designed for AMDHSA, it looks for keys that have `amdhsa` (e.g. `amdhsa.version`) and fails when it doesn't find them


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146119/new/

https://reviews.llvm.org/D146119



More information about the llvm-commits mailing list