[PATCH] D146137: [AMDGPU] Select flat atomic fmin/fmax

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 05:56:42 PDT 2023


mbrkusanin marked 2 inline comments as done.
mbrkusanin added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/fp-min-max-flat-atomics-f64.ll:3
+; RUN: llc < %s -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs | FileCheck %s -check-prefix=GFX10-SDAG
+; RUN: llc < %s -global-isel -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs | FileCheck %s -check-prefix=GFX10-GISEL
+
----------------
rampitec wrote:
> Add prefix GCN to both lines, that way autogenerated checks will be common for SDAG and ISel if match. Here and in other tests.
Added common GFX10 and GFX11 check labels across tests because SDAG and GISel can match. Instruction was renamed for GFX11 so I did not add GCN label for all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146137/new/

https://reviews.llvm.org/D146137



More information about the llvm-commits mailing list