[PATCH] D146061: [ADT] Make llvm::is_contained call member `contains` or `find` when available

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 03:06:31 PDT 2023


uabelho added a comment.

I ran into a fun thing with this.
In my downstream backend we have a class where we apparently implemented "contains" by calling "llvm::is_contained".
With this patch that's not a very good idea as it then just calls itself over and over again.

Just a heads up in case someone else sees a hanging compiler and bisects back to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146061/new/

https://reviews.llvm.org/D146061



More information about the llvm-commits mailing list