[PATCH] D146196: [InstSimplify] make simplifyUnsignedRangeCheck commutative for ZeroICmp

Kohei Asano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 01:57:52 PDT 2023


khei4 abandoned this revision.
khei4 added a comment.

In D146196#4198590 <https://reviews.llvm.org/D146196#4198590>, @nikic wrote:

> InstCombine canonicalizes constant icmp operands to the RHS, this is why constants are not usually handled on the LHS. Unless there is some PhaseOrdering reason why it is important to handle this pattern prior to the first InstCombine run, we shouldn't do this.

Oh, now I could have found that canonicalization <https://github.com/llvm/llvm-project/blob/main/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp#L382-L402>. Thank you!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146196/new/

https://reviews.llvm.org/D146196



More information about the llvm-commits mailing list