[PATCH] D145645: [RISCV] Print Zfa fli instruction FP values in a more adaptive way.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 01:51:17 PDT 2023


craig.topper added a comment.

In D145645#4198564 <https://reviews.llvm.org/D145645#4198564>, @joshua-arch1 wrote:

> I'm wondering why you print values other than 1*2^-15 and 1*2^-16 without scientific notation. From my perspective, for one instruction, we need to keep the operands relatively consistent only in some particular occasions (like min/inf/nan).

I wanted to present the least amount of information so it was easy to read. The instructions are going to be scattered in a binary. They aren’t often going to appear in a grouping where the inconsistency is noticeable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145645/new/

https://reviews.llvm.org/D145645



More information about the llvm-commits mailing list