[PATCH] D146119: [llvm-readobj][AMDGPU] Bypass MD verification for PAL

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 01:23:44 PDT 2023


jhenderson added a comment.

One nit from me. Somebody who understands AMDGPU will need to do a proper review though.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5436
+    // FIXME: Metadata Verifier doesn't work with AMDPAL MD.
+    //  This is a ugly workaround to avoid the verifier.
+    if (MsgPackString.find("amdpal.") == StringRef::npos) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146119/new/

https://reviews.llvm.org/D146119



More information about the llvm-commits mailing list