[PATCH] D122207: [IROutliner][IRSim] Add all outlined region basic blocks to canonical numbering to add basic blocks to generated PHINode numbering generation.

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:1049
+    Value *SourceV = *SourceCand.fromGVN(SourceGVN);
+    BasicBlock *SourceBB = cast<Instruction>(SourceV)->getParent();
+    unsigned SourceBBGVN = *SourceCand.getGVN(SourceBB);
----------------
AndrewLitteken wrote:
> AndrewLitteken wrote:
> > uabelho wrote:
> > > Hi @AndrewLitteken ,
> > > 
> > > The following command crashes on this cast:
> > > ```
> > > opt -passes="function(loop-mssa(loop-rotate,licm<allowspeculation>,simple-loop-unswitch<nontrivial;trivial>)),require<ir-similarity>" bbi-80271.ll -o /dev/null
> > > ```
> > > When it crashes SourceV is this:
> > > ```
> > > (gdb) p SourceV->dump()
> > > i16 1
> > > ```
> > > The input is reduced with llvm-reduce and I've tried to shorten the command with utils/reduce_pipeline.py but it's still rather large and ugly.
> > > {F26801948}
> > Can you check if this patch: https://reviews.llvm.org/D139337 fixes the issue? This was fixed in a future refactoring for compilation speed and seems to work on my build.
> Sorry, this is not correct, it should be this patch: https://reviews.llvm.org/D139336
Yes, with https://reviews.llvm.org/D139336 the crash I see goes away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122207/new/

https://reviews.llvm.org/D122207