[PATCH] D145634: [X86] Support llvm.{min,max}imum.f{16,32,64}

[Phoebe Wang via Phabricator via llvm-commits]

pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:29931
+    MinMax = DAG.getNode(MinMaxOp, DL, VT, Y, X, Op->getFlags());
+  } else if ((VT == MVT::f16 || Subtarget.hasDQI()) &&
+             (Op->getFlags().hasNoNaNs() || IsXNeverNaN || IsYNeverNaN)) {
----------------
pengfei wrote:
> pengfei wrote:
> > `(VT == MVT::f16 && Subtarget.hasFP16()) || Subtarget.hasDQI()`
> Sorry, mistake. It should be:
> `(VT != MVT::f16 && Subtarget.hasDQI()) || Subtarget.hasFP16()`
Oh, we have checked `hasFP16` in line 29876. So the way used here is correct. Sorry for the noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145634/new/

https://reviews.llvm.org/D145634