[PATCH] D146185: [SystemZ] Allow any I5 in RotateSelect*

Ilya Leoshkevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 18:24:18 PDT 2023


iii created this revision.
iii added reviewers: uweigand, jonpa.
Herald added a subscriber: hiraditya.
Herald added a project: All.
iii requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

For all RotateSelect* instructions, PoP says:

  Bits 0-1 of the I5 field (bits 32-33 of the instruction) are
  ignored.

LLVM, however, completely prohibits using them, e.g.:

  error: invalid operand for instruction
  asm("rxsbg %[r1],%[r2],177,43,228\n"

Lift this unnecessary restriction.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146185

Files:
  llvm/lib/Target/SystemZ/SystemZInstrFormats.td
  llvm/test/MC/SystemZ/insn-bad-z196.s
  llvm/test/MC/SystemZ/insn-bad-zEC12.s
  llvm/test/MC/SystemZ/insn-bad.s
  llvm/test/MC/SystemZ/insn-good-z196.s
  llvm/test/MC/SystemZ/insn-good-zEC12.s
  llvm/test/MC/SystemZ/insn-good.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146185.505678.patch
Type: text/x-patch
Size: 11295 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230316/65d5a3a0/attachment.bin>


More information about the llvm-commits mailing list