[PATCH] D142746: AMDGPU: Fold fneg into bitcast of build_vector

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 17:47:19 PDT 2023


arsenm added a comment.

Rebase had a few regressions due to the revert of 11c3cead23783e65fb30e673d62771352078ff05 <https://reviews.llvm.org/rG11c3cead23783e65fb30e673d62771352078ff05>



================
Comment at: llvm/test/CodeGen/AMDGPU/fneg-modifier-casting.ll:519
+; GFX11-NEXT:    v_and_b32_e32 v1, 1, v1
+; GFX11-NEXT:    s_delay_alu instid0(VALU_DEP_3) | instskip(SKIP_1) | instid1(VALU_DEP_4)
 ; GFX11-NEXT:    v_cmp_eq_u32_e32 vcc_lo, 1, v0
----------------
Pierre-vh wrote:
> There's a small regression here (1 extra instruction), is that addressed in a next patch?
Yes, there's additional source modifier usage after D142749


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142746/new/

https://reviews.llvm.org/D142746



More information about the llvm-commits mailing list