[PATCH] D146025: [RISCV][NFC] Add more tests for SLP vectorization

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 15:11:33 PDT 2023


reames added a comment.

It's not really clear to me what value the new tests are adding.  At a minimum, this should probably be a different test file.  The file you're modifying was intended to focus on the load/store vectorization - the add was only there to provide some use chain between the load and stores.

If you wanted to add some wider examples, that might be useful though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146025/new/

https://reviews.llvm.org/D146025



More information about the llvm-commits mailing list