[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

FYI, zvkb was discussed at the Architectural Review Committee this week and they've asked for some significant changes and expansions.  See the notes shared here: https://lists.riscv.org/g/tech-unprivileged/message/450

I actively do not think we need to wait on landing this patch until those expansions have been finalized.  I think is fine to land this in experimental state, and then transform zvkb into the requested form.   Having a generic vector bitmanip extension pulled out seems to make a lot of sense to me, and I like (most of) the proposed additions as they close holes we've encountered in codegen.

I've skimmed the review and didn't spot anything glaring, but want to leave approval to @craig.topper since he's already done one pass and is generally more familiar with the MC layer than I am.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141672/new/

https://reviews.llvm.org/D141672