[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

Wed Mar 15 12:48:37 PDT 2023

qiongsiwu1 added a comment.

@arsenm @MaskRay and @serge-sans-paille, I would like to draw your attention to this patch. We would like to get your advice on the following issues:

1. We would like to do some error check in `llc` to guard against invalid option combinations. Doing the checks in `llc`'s `main` feels out of place. Doing it in `InitTargetOptionsFromCodeGenFlags()` https://github.com/llvm/llvm-project/blob/4c82050c56926d840e4ccf253ad10e6ae3ee6cc7/llvm/lib/CodeGen/CommandFlags.cpp#L517 probably makes more sense, but we do not perform any error checks there at the moment. What is a good place to perform such error checks? This is related to https://reviews.llvm.org/D144190#4180329, where we are looking for advice on how to check codegen options when doing a pure linking job. **What is the expected behaviour if an option that is not technically generic (such as this `-mroptr` option that only makes sense for XCOFF on AIX), but not architecture specific (in theory we may have XCOFF running on other platforms) either? **
2. We are touching some target-independent files to implement this option. Earlier @myhsu  pointed out that this might be a subtarget feature https://reviews.llvm.org/D144189#4132940 and we argued that it is not https://reviews.llvm.org/D144189#4144677 because this is an AIX/XCOFF issue. We would like to notify you all and make sure you are ok with this as well.

Thanks so much!!

FYI @nemanjai  @hubert.reinterpretcast

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189