[PATCH] D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges

Markus Böck via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 10:44:52 PDT 2023


zero9178 accepted this revision.
zero9178 added a comment.

LGTM!



================
Comment at: llvm/include/llvm/ADT/STLExtras.h:2206
+/// and fully conforms to the C++20 definition of forward iterator.
+/// This is similar to `std::vector<bool>>::iterator` that returns bit reference
+/// wrappers on dereference.
----------------



================
Comment at: llvm/include/llvm/ADT/STLExtras.h:2242
+  decltype(auto) value() const {
+    if constexpr (NumRefs == 1) {
+      return std::get<0>(Storage);
----------------
nit: remove trivial braces here and below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144503/new/

https://reviews.llvm.org/D144503



More information about the llvm-commits mailing list