[PATCH] D144925: [RISCV][NFC] Replace the pseudos for instructions that depend on lmul with variants that encode the SEW into the name

[Michael Maitland via Phabricator via llvm-commits]

michaelmaitland requested changes to this revision.
michaelmaitland added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2337
+        defvar ReadVFSqrtV_MX = !cast<SchedRead>("ReadVFSqrtV_" # mx # "_E" # e);
+        defvar suffix = mx # "_E" # e;
+
----------------
nitinjohnraj wrote:
> michaelmaitland wrote:
> > Use `suffix` in `WriteVFSqrtV_MX` and `ReadVFSqrtV_MX`. Also need to add `_E` to  `WriteVFSqrtV_MX` and `ReadVFSqrtV_MX`
> Thanks, will do!
`defvar WriteVFSqrtV_MX_E` and `defvar WriteVFSqrtV_MX_E`


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2350
 
+// TODO: Should I make this SEW aware?
 multiclass VPseudoVRCP_V {
----------------
craig.topper wrote:
> michaelmaitland wrote:
> > Where did you land on making this SEW aware?
> I think the answer is no.
If this does not need to be SEW aware, should we remove the TODO?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144925/new/

https://reviews.llvm.org/D144925