[PATCH] D145515: [Assignment Tracking][NFC] Only calculate fragment overlaps for partially stack homed variables

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

/me squints -- so if no part of the variable ends up on the stack, this is effectively early-exiting this portion of analysis?



================
Comment at: llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp:1879
 static AssignmentTrackingLowering::OverlapMap buildOverlapMapAndRecordDeclares(
-    Function &Fn, FunctionVarLocsBuilder *FnVarLocs,
+    Function &Fn, const DenseSet<DebugAggregate> *VarsWithStackSlot,
+    FunctionVarLocsBuilder *FnVarLocs,
----------------
scott.linder wrote:
> I would prefer a reference type, assuming there is no possibility that it is `nullptr`.
+1,


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145515/new/

https://reviews.llvm.org/D145515