[PATCH] D145583: [AArch64][SME] Fix an infinite loop in DAGCombine related to adding -force-streaming-compatible-sve flag.

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 09:08:35 PDT 2023


david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/aarch64-force-streaming-compatible-sve.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple aarch64-none-linux-gnu -mattr=+sve -force-streaming-compatible-sve | FileCheck %s --check-prefix=CHECK
----------------
I think it makes sense to move this test into one of the existing files, perhaps something like CodeGen/AArch64/sve-streaming-mode-fixed-length-int-extends.ll?


================
Comment at: llvm/test/CodeGen/AArch64/aarch64-force-streaming-compatible-sve.ll:4
+
+define void @jpeg_add_quant_table(i32 %0, <8 x i64> %1, ptr %2) {
+; CHECK-LABEL: jpeg_add_quant_table:
----------------
sdesmalen wrote:
> Just a general comment (and not a suggestion for this patch): It would be nice if we could use SVE's `[us]mull[bt]` instructions for this.
I think it would be good to rename this function to something that is more meaningful, perhaps extend_cmp_of_mul? Also, I think it would be nice to add a comment that describes what we're testing here, i.e. that the DAG combiner does not get stuck in an infinite loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145583/new/

https://reviews.llvm.org/D145583



More information about the llvm-commits mailing list