[PATCH] D146071: [AIX] unset bit "IsBackChainStored" of traceback table for leaf functions with no stack frame

Wed Mar 15 06:43:33 PDT 2023

DiggerLin added a comment.

In D146071#4194372 <https://reviews.llvm.org/D146071#4194372>, @stephenpeckham wrote:

> Are there still tests where IsBackChainStored is true?

yes,

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2136

   // Always store back chain.
+  SecondHalfOfMandatoryField |= MF->getFrameInfo().getStackSize()
----------------
stephenpeckham wrote:
> Comment no longer applies
thanks

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:2137
   // Always store back chain.
-  SecondHalfOfMandatoryField |= MF->getFrameInfo().getFrameSize() ? TracebackTable::IsBackChainStoredMask : 0;

----------------
shchenz wrote:
> Are you using the wrong diff baseline? Seems like the left side is a local commit of your working branch? In the main trunk, I see
> ```
>   // Always store back chain.
>   SecondHalfOfMandatoryField |= TracebackTable::IsBackChainStoredMask;
> ```
yes, left side is working. thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146071/new/

https://reviews.llvm.org/D146071