[PATCH] D146119: [llvm-readobj][AMDGPU] Bypass MD verification for PAL

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5435
+
+    // FIXME: Metadata Verifier doesn't work with AMDPAL MD.
+    //  This is a ugly workaround to avoid the verifier.
----------------
Why, I don't understand?


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5438
+    if (MsgPackString.find("amdpal.") == StringRef::npos) {
+      AMDGPU::HSAMD::V3::MetadataVerifier Verifier(true);
+      if (!Verifier.verify(MsgPackDoc.getRoot()))
----------------
Why isn't this on only under an assert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146119/new/

https://reviews.llvm.org/D146119