[PATCH] D75357: [X86] Add a private member function determinePaddingPrefix for X86AsmBackend

[Alexander Potapenko via Phabricator via llvm-commits]

glider added inline comments.
Herald added a subscriber: pengfei.
Herald added a project: All.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:350
+/// If the instruction has a segment override prefix, use the existing one.
+/// If the target is 64-bit, use the CS.
+/// If the target is 32-bit,
----------------
Hi Shengchen,

Out of curiosity, why does this feature use CS instead of DS for instruction padding?

Also, is there an easy way to trigger this behavior in Clang? I couldn't find any tests for this functionality.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75357/new/

https://reviews.llvm.org/D75357