[PATCH] D146118: [X86]add assert to confirm not-null ptr in getArithmeticReductionCost

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 03:34:54 PDT 2023


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - a reduction cost is almost impossible without the type anyhow



================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:2337
                                              TTI::TargetCostKind CostKind) {
+    assert(Ty && "Unexpected argument types");
     if (TTI::requiresOrderedReduction(FMF))
----------------
Maybe "Unknown reduction vector type" ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146118/new/

https://reviews.llvm.org/D146118



More information about the llvm-commits mailing list