[PATCH] D145042: [NFC][SCEV] Changed the return type of some functions from ScalarEvolution

Dmitry Bakunevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 03:08:15 PDT 2023


dbakunevich added a comment.

In D145042#4191612 <https://reviews.llvm.org/D145042#4191612>, @mkazantsev wrote:

> Let's not do it. Making everyone include this header just because of this reason is an overkill.

Why is this overkill? The ScalarEvolutionExpression class contains a SCEVConstant class definition that defines the SCEVConstant class as inherit of the SCEV class. This information allows us to cast. Without connecting a class, it is impossible to make a cast.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145042/new/

https://reviews.llvm.org/D145042



More information about the llvm-commits mailing list