[PATCH] D140202: [lld][ARM][2/3]Big Endian support - Word invariant support
Simi Pallipurath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 15 02:23:21 PDT 2023
simpal01 added a comment.
================
Comment at: lld/ELF/Driver.cpp:347
if (config->fixCortexA8 && config->emachine != EM_ARM)
error("--fix-cortex-a8 is only supported on ARM targets");
----------------
peter.smith wrote:
> This would be the place to move the check from ARMErrataFix.cpp.
>
> Message text could be something like `--fix-cortex-a8 is not supported on big-endian targets`
>
> I also suggest adding an error message for --be32 on emachine != EM_ARM
Now i have set be32 in Config.h with
**bool be32 = false;**
And again setting this value in setConfigs with
**config->be32 = (k==ELF32BEKIND && m==EM_ARM);**
And when we implement --be8 switch, my plan is to change this to
config->be32 = (k==ELF32BEKIND && m==EM_ARM && !config->be8);
where config->be8 will be
config->be8 = args.hasArg(OPT_be8);
Since i am setting the be32 value only when emachine = EM_ARM, i am not sure if we still need to add an error message for --be32 on emachine!=EM_ARM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140202/new/
https://reviews.llvm.org/D140202
More information about the llvm-commits
mailing list