[PATCH] D131587: [CodeGen] Deduplicate restore blocks in branch relaxation

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: llvm/lib/CodeGen/BranchRelaxation.cpp:105
+          return ItOld == ItEndOld && ItNew == ItEndNew;
+        if (!ItOld->isIdenticalTo(*ItNew))
+          return false;
----------------
piggynl wrote:
> arsenm wrote:
> > Does this also need to consider the various flags on the block (e.g. alignment)?
> No target is constructing the restore block with flagged instructions at this time. I've added a FIXME here.
Could we bail out on that or at least assert?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131587/new/

https://reviews.llvm.org/D131587