[PATCH] D142084: [RFC][X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/utils/TableGen/X86FoldTablesEmitter.cpp:130
+      bool RHSpseudo = RHS->TheDef->getValueAsBit("isPseudo");
+      if (LHSpseudo != RHSpseudo)
+        return LHSpseudo;
----------------
yubing wrote:
> skan wrote:
> > Why do we need to compare `isPseudo`?
> I copy the code from "bool operator<(const X86FoldTableEntry &RHS) const {", 
> @craig.topper , i saw the author of "bool operator<(const X86FoldTableEntry &RHS) const {" is you. do you still remember why we need to compare isPseudo here?
I think it's a NFC change from me. If we remove this comparison, will any test fail?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084