[PATCH] D143180: DAG: Expand legalization of is.fpclass to fcmp for DAZ

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added inline comments.


================
Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:148
+  /// Return true if input denormals must be implicitly treated as 0.
+  constexpr bool inputsAreZero() const {
+    return Input == DenormalModeKind::PreserveSign ||
----------------
The function name is not verb-based. Maybe `treatInputAsZero` or something like that?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:8012
+/// for the floating-point mode.
+static FPClassTest isFCmpEqualZero(FPClassTest Test,
+                                   const fltSemantics &Semantics,
----------------
It looks like this function should return boolean value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143180/new/

https://reviews.llvm.org/D143180