[PATCH] D145657: [CodeGen] Retry landing D42600 - Precommit test

Tue Mar 14 22:28:56 PDT 2023

sushgokh added a comment.

In D145657#4194133 <https://reviews.llvm.org/D145657#4194133>, @nickdesaulniers wrote:

> Thanks for taking over D42600 <https://reviews.llvm.org/D42600>!
>
> Please drop
>
>> D42600 <https://reviews.llvm.org/D42600> couldnt land for some reasons.
>
> from the commit message.  It's irrelevant now that you've commandeered D42600 <https://reviews.llvm.org/D42600>.
>
> Consider making this test into a MIR test that uses `-run-only=shrink-wrap` rather than testing the entire backend. You can use `llc -stop-before=<passname>` to dump MIR, and `llc -start-before=<passname>` to restart the whole backend from a given starting pass (or more simply `-run-only=<passname>` to test one backend pass in isolation.  I strongly encourage you to change this test, but wont block landing this or D42600 <https://reviews.llvm.org/D42600> on it.
>
> Approving, but please do not commit until D42600 <https://reviews.llvm.org/D42600> has been approved, and please commit them together at roughly the same time (keep them two distinct commits though).

Thanks for the suggestions. I had thought of converting this to MIR but I was of perception that changes to block layout are easily identified in the assembly. But you are right in order to avoid other changes peeking in and reducing load while testing. WIll convert to MIR test.

Also, will freshly put the changes for D42600 <https://reviews.llvm.org/D42600> for review and simultaneously commit both as you suggest.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145657/new/

https://reviews.llvm.org/D145657