[PATCH] D145680: [DWARFLinker][DWARFv5] Support debug_loclists.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.

LGTM modulo some nits in the comments.



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:133
 
+  /// Emit debug locations(.debug_loc, .debug_loclists) header.
+  virtual MCSymbol *emitDwarfDebugLocListHeader(const CompileUnit &Unit) = 0;
----------------



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:136
+
+  /// Emit debug locations(.debug_loc, .debug_loclists) fragment.
+  virtual void emitDwarfDebugLocListFragment(
----------------



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:142
+
+  /// Emit debug locations(.debug_loc, .debug_loclists) footer.
+  virtual void emitDwarfDebugLocListFooter(const CompileUnit &Unit,
----------------



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:752
+
+  /// Compute and emit debug locations(.debug_loc, .debug_loclists)
+  /// for \p Unit, patch the attributes referencing it.
----------------



================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:1776
+      llvm::consumeError(OriginalLocations.takeError());
+      reportWarning("invalid location attribute ignored.", File);
+      continue;
----------------
Other warnings start with a capital. 


================
Comment at: llvm/lib/DWARFLinker/DWARFStreamer.cpp:544
+
+  // Make .debug_loclists to be current section.
+  MS->switchSection(MC->getObjectFileInfo()->getDwarfLoclistsSection());
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145680/new/

https://reviews.llvm.org/D145680