[PATCH] D140788: [DWARFLinkerParallel] add AddressesMap interface.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGMT with some wordsmithing



================
Comment at: llvm/include/llvm/DWARFLinkerParallel/AddressesMap.h:31-32
+
+  /// Checks that there are valid relocations against a .debug_info
+  /// section.
+  virtual bool hasValidRelocs() = 0;
----------------



================
Comment at: llvm/include/llvm/DWARFLinkerParallel/AddressesMap.h:35-40
+  /// Checks that the specified variable \p DIE references the live code
+  /// section and returns the relocation adjustment value(to get the linked
+  /// address this value might be added to the source variable address).
+  /// Allowed kind of input die: DW_TAG_variable, DW_TAG_constant.
+  /// \returns relocation adjustment value or std::nullopt if there is not
+  /// corresponding live address.
----------------



================
Comment at: llvm/include/llvm/DWARFLinkerParallel/AddressesMap.h:44-49
+  /// Checks that the specified subprogram \p DIE references the live code
+  /// section and returns the relocation adjustment value(to get the linked
+  /// address this value might be added to the source subprogram address).
+  /// Allowed kind of input die: DW_TAG_subprogram, DW_TAG_label.
+  /// \returns relocation adjustment value or std::nullopt if there is not
+  /// corresponding live address.
----------------



================
Comment at: llvm/include/llvm/DWARFLinkerParallel/AddressesMap.h:60-61
+
+  /// Returns all valid functions address ranges(i.e., those ranges
+  /// which points to sections with code).
+  virtual RangesTy &getValidAddressRanges() = 0;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140788/new/

https://reviews.llvm.org/D140788