[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

Tue Mar 14 21:22:03 PDT 2023

hubert.reinterpretcast added inline comments.

================
Comment at: llvm/tools/llc/llc.cpp:513
+      if (!Options.DataSections)
+        reportError("-mroptr option must be used with -data-sections",
+                    InputFilename);
----------------
hubert.reinterpretcast wrote:
> See https://reviews.llvm.org/D144190#inline-1406700 for why having this diagnostic in `llc` may not be the best.
Since the back end now errors out reliably (`report_fatal_error`), the comment linked above for the other patch implies that we can remove this `llc` diagnostic in this patch. Then we can land this patch first.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189