[PATCH] D145634: [X86] Support llvm.{min,max}imum.f{16,32,64}

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.

In D145634#4194990 <https://reviews.llvm.org/D145634#4194990>, @e-kud wrote:

> In D145634#4187914 <https://reviews.llvm.org/D145634#4187914>, @pengfei wrote:
>
>> In D145634#4187888 <https://reviews.llvm.org/D145634#4187888>, @e-kud wrote:
>>
>>> In D145634#4183847 <https://reviews.llvm.org/D145634#4183847>, @pengfei wrote:
>>>
>>>> Do you have plan to support `minimumNumber`?
>>>
>>> Sorry, I didn't get it. Could you be more specific?
>>
>> It's accompanying function of `minimum` in IEEE-754 2019, it will be introduced in new C/C++ standard too. I thought you are working for that.
>
> I can't find any lib calls or specific intrinsics for them. I'd like to add them separately if we have any users or needs of them, do we?

I heard glibc is supporting them. I'm fine with leaving it to the future. Do you have plan on the vector support?



================
Comment at: llvm/test/CodeGen/X86/fminimum-fmaximum.ll:4
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx     | FileCheck %s --check-prefixes=AVX,AVX1
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512f | FileCheck %s --check-prefixes=AVX,AVX512
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512dq | FileCheck %s --check-prefixes=AVX,AVX512,AVX512DQ
----------------
Guess you missed a AVX512F, i.e. `AVX,AVX512,AVX512F`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145634/new/

https://reviews.llvm.org/D145634