[PATCH] D145772: [Instcombine] Canonicalize all <=> patterns to (a>b)-(a<b)

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 18:09:15 PDT 2023


bcl5980 added a comment.

In D145772#4192188 <https://reviews.llvm.org/D145772#4192188>, @nikic wrote:

> Was this abandoned because it breaks some of the existing optimizations? For the record, this is how the compare-3way.ll test diff looks like: https://gist.github.com/nikic/056516a0d621f9ca69059d05eef7e7b2

Yeah, I haven't found a quick way to fix the test failures. So, I abandon it for now. Need more time to detect the canonicalized form in `matchThreeWayIntCompare`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145772/new/

https://reviews.llvm.org/D145772



More information about the llvm-commits mailing list