[PATCH] D145966: [WebAssembly] Replace Bugzilla links with Github issues

[Heejin Ahn via Phabricator via llvm-commits]

aheejin updated this revision to Diff 505339.
aheejin added a comment.
Herald added subscribers: ormris, steven_wu.

Add more bugzilla links in lld


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145966/new/

https://reviews.llvm.org/D145966

Files:
  lld/test/wasm/lto/pic-empty.s
  lld/wasm/InputFiles.cpp
  lld/wasm/Writer.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
  llvm/lib/Target/WebAssembly/WebAssemblyNullifyDebugValueLists.cpp


Index: llvm/lib/Target/WebAssembly/WebAssemblyNullifyDebugValueLists.cpp
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyNullifyDebugValueLists.cpp
+++ llvm/lib/Target/WebAssembly/WebAssemblyNullifyDebugValueLists.cpp
@@ -9,7 +9,7 @@
 /// \file
 /// Nullify DBG_VALUE_LISTs instructions as a temporary measure before we
 /// implement DBG_VALUE_LIST handling in WebAssemblyDebugValueManager.
-/// See https://bugs.llvm.org/show_bug.cgi?id=50361.
+/// See https://github.com/llvm/llvm-project/issues/49705.
 /// TODO Correctly handle DBG_VALUE_LISTs
 ///
 //===----------------------------------------------------------------------===//
Index: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
+++ llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp
@@ -1217,7 +1217,7 @@
     for (unsigned I = 0, E = LPI->getNumClauses(); I < E; ++I) {
       Constant *Clause = LPI->getClause(I);
       // TODO Handle filters (= exception specifications).
-      // https://bugs.llvm.org/show_bug.cgi?id=50396
+      // https://github.com/llvm/llvm-project/issues/49740
       if (LPI->isCatch(I))
         FMCArgs.push_back(Clause);
     }
Index: lld/wasm/Writer.cpp
===================================================================
--- lld/wasm/Writer.cpp
+++ lld/wasm/Writer.cpp
@@ -476,7 +476,7 @@
   if (config->isPic) {
     // This should not be necessary because all PIC objects should
     // contain the mutable-globals feature.
-    // TODO(https://bugs.llvm.org/show_bug.cgi?id=52339)
+    // TODO (https://github.com/llvm/llvm-project/issues/51681)
     allowed.insert("mutable-globals");
   }
 
Index: lld/wasm/InputFiles.cpp
===================================================================
--- lld/wasm/InputFiles.cpp
+++ lld/wasm/InputFiles.cpp
@@ -441,7 +441,7 @@
   // called directly (i.e. only address taken) don't have to match the defined
   // function's signature.  We cannot do this for directly called functions
   // because those signatures are checked at validation times.
-  // See https://bugs.llvm.org/show_bug.cgi?id=40412
+  // See https://github.com/llvm/llvm-project/issues/39758
   std::vector<bool> isCalledDirectly(wasmObj->getNumberOfSymbols(), false);
   for (const SectionRef &sec : wasmObj->sections()) {
     const WasmSection &section = wasmObj->getWasmSection(sec);
@@ -791,7 +791,8 @@
   }
   checkArch(t.getArch());
   std::vector<bool> keptComdats;
-  // TODO Support nodeduplicate https://bugs.llvm.org/show_bug.cgi?id=50531
+  // TODO Support nodeduplicate
+  // https://github.com/llvm/llvm-project/issues/49875
   for (std::pair<StringRef, Comdat::SelectionKind> s : obj->getComdatTable())
     keptComdats.push_back(symtab->addComdat(s.first));
 
Index: lld/test/wasm/lto/pic-empty.s
===================================================================
--- lld/test/wasm/lto/pic-empty.s
+++ lld/test/wasm/lto/pic-empty.s
@@ -3,7 +3,7 @@
 ; We had a bug where the mutable-globals feature was not being added
 ; so the linker-generated import of `__stack_pointer` (which is currently
 ; mandatory for ; shared libraries) was generating a linker error.
-; See https://bugs.llvm.org/show_bug.cgi?id=52339
+; See https://github.com/llvm/llvm-project/issues/51681.
 
 ; RUN: llvm-as %s -o %t.o
 ; RUN: wasm-ld --lto-O2 --experimental-pic -shared --no-gc-sections --export=tls_int %t.o -o %t.so


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145966.505339.patch
Type: text/x-patch
Size: 3560 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230315/f2c65782/attachment.bin>