[PATCH] D146105: [AArch64] Add hex comments to mov-imm spellings in the InstPrinter

Jon Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 17:17:54 PDT 2023


jroelofs added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/movw-consts.ll:157
 ; CHECK-NEXT:    adrp x8, _var32 at PAGE
-; CHECK-NEXT:    mov w9, #-1
+; CHECK-NEXT:    mov w9, #-1 ; =0xffffffffffffffff
 ; CHECK-NEXT:    str w9, [x8, _var32 at PAGEOFF]
----------------
Would it be better if the comment's bitwidth matched the register's bitwidth?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146105/new/

https://reviews.llvm.org/D146105



More information about the llvm-commits mailing list