[PATCH] D146099: [Pipeline] Remove early InstCombine in ThinLTO post link sample profile pipeline

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 17:07:34 PDT 2023


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm, but please wait to see if @davidxl wants to re-anchor any of the comments there, specifically the FIXME.



================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:976
-  // https://research.google.com/pubs/pub45290.html
-  // FIXME: revisit how SampleProfileLoad/Inliner/ICP is structured.
-  if (LoadSampleProfile)
----------------
@davidxl is this comment still needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146099/new/

https://reviews.llvm.org/D146099



More information about the llvm-commits mailing list