[PATCH] D145873: Move definitions of ArgKind from Intrinsics.h to Intrinsics.td

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added inline comments.


================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:176
+  if (auto RecArgKind = Records.getDef("ArgKind")) {
+    for (auto &Rec : RecArgKind->getValues())
+      OS << "    AK_" << Rec.getName() << " = " << *Rec.getValue() << ",\n";
----------------
craig.topper wrote:
> `Rec` confused me at first. These aren't Records. I think they are RecordVal? `RV` or `Field` would be a better name.
Makes sense. I was confused, too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145873/new/

https://reviews.llvm.org/D145873