[PATCH] D145515: [Assignment Tracking][NFC] Only calculate fragment overlaps for partially stack homed variables

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 15:57:45 PDT 2023


scott.linder added inline comments.


================
Comment at: llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp:1879
 static AssignmentTrackingLowering::OverlapMap buildOverlapMapAndRecordDeclares(
-    Function &Fn, FunctionVarLocsBuilder *FnVarLocs,
+    Function &Fn, const DenseSet<DebugAggregate> *VarsWithStackSlot,
+    FunctionVarLocsBuilder *FnVarLocs,
----------------
I would prefer a reference type, assuming there is no possibility that it is `nullptr`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145515/new/

https://reviews.llvm.org/D145515



More information about the llvm-commits mailing list