[PATCH] D143844: llvm-tblgen: Split out CodeGenIntrinsics.cpp from CodeGenTarget.cpp

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 15:31:20 PDT 2023


chapuni added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenIntrinsics.h:29
+// FIXME: Sweep this in the near future.
+namespace tmp {
+/// getValueType - Return the MVT::SimpleValueType that the specified TableGen
----------------
chapuni wrote:
> arsenm wrote:
> > Drop the tmp namespace?
> Let me know better wording. I will drop entire `llvm::tmp::getValueType()` and its namespace.
`FIXME: Remove this when no longer needed.`

I'll update the comment and commit it. Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143844/new/

https://reviews.llvm.org/D143844



More information about the llvm-commits mailing list