[PATCH] D145962: [lld] Fill .text section gaps with INT3 only on x86 targets.

[Jacek Caban via Phabricator via llvm-commits]

jacek added inline comments.


================
Comment at: lld/test/COFF/gaps-fill.test:11
+# CHECK: 180001004: d65f03c0     ret
+# CHECK:                         ...
+# CHECK: 180001010: 52800040     mov     w0, #0x2
----------------
mstorsjo wrote:
> Is this a case where `llvm-objdump` prints just `...` for contiguous areas with plain zeros? (I guess that's primarily what this test should be looking for - it seems a bit odd that that checked aspect is so implicit here.)
Yes, that seems to be its feature (countSkippableZeroBytes in llvm-objdump.cpp). I noticed that there is -z/--disassemble-zeroes option to disable this feature, I will change the test to use that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145962/new/

https://reviews.llvm.org/D145962